Test code extraction for exercises with separate file for test cases #107
Conversation
|
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
This commit also support arbitrary test data variable name when test function includes multiple assignments.
meoconbatu
force-pushed
the
merge-separate-cases-test-file
branch
from
d535464 to
21b939f
Compare
There was a problem hiding this comment.
After these changes, the tests for the conditionals testdata exercise don't compile anymore. It would be great if that could be fixed so go run . testrunner/testdata/concept/conditionals outdir works again. This command is mentioned in the readme so it makes sense it works. Having a runnable example (not only a unit test) also helps double checking the output is correct.
Maybe it would be best you work on a copy of the exercise in a folder called separate_cases_file. Then the current conditionals test data could stay as is and for your new folder/exercise we could even add an entry in integration_test.go to make sure the "end2end" output is as expected. (The tests are more like regression/snapshot tests. To set one up, print the "got" result of the test to the console and paste it into a file in the "expected" folder, given it looks correct of course.)
junedev
added
x:rep/large
|
@ErikSchierboom This should be good to go. I will do some more testing but would be good if you can stamp it. |
4 participants
Fixes #80
This commit also supports arbitrary test data variable name when test function includes multiple assignments.
Recreate the PR from @junedev suggestion in #105 (comment)